Lock screen (main-window overlay, no second window): - scrypt password verifier in <userData>/lock.json (per-write salt, timingSafeEqual); salt/hash/password never leave the main process - lock now / idle auto-lock / lock at startup, growing failure cooldown, lock flags persisted so a quit-and-relaunch cannot bypass the lock - locked shell and body portals go inert while sessions keep running; menu accelerators (reload, DevTools, zoom) are swallowed while locked - settings gains a Lock tab; all copy in zh-CN/zh-TW/en/ja Security and stability: - packaged builds ignore ELECTRON_RENDERER_URL / OT_UPDATE_URL (devEnv) - renderer preload runs with sandbox: true - unreadable known_hosts store fails closed instead of being overwritten - connect-time secrets gated by the bookmark's auth method (connectPromptFor) - ssh stream teardown is idempotent: PTY_EXIT broadcasts exactly once - sysinfo polling is refcounted for split panes (forceStopPolling on close) - session-log index entries are path-contained; settings store writes atomically with EPERM/EBUSY retry - sync-changelog tolerates CRLF checkouts (was a silent no-op) - retry ssh2 host-key generation (flaky malformed key, ~1/500) Tests: lock-store + lock-controller suites; transport-death PTY_EXIT e2e; GitHub Actions CI (typecheck + 10 offline tests + build)
178 lines
5.3 KiB
JavaScript
178 lines
5.3 KiB
JavaScript
/**
|
|
* SSH loopback verification (M2). Pure Node ESM, no Electron.
|
|
*
|
|
* Spins up an in-process ssh2.Server (127.0.0.1, random port), then connects
|
|
* with a plain ssh2.Client using the exact same connect parameters the main
|
|
* process ssh service uses (host/port/username/password/keepalive/hostVerifier),
|
|
* and confirms the full data plane round-trip:
|
|
*
|
|
* ready -> shell -> banner "LOOPBACK-OK" -> write data -> echo -> close
|
|
*
|
|
* Run: `node tests/ssh-loopback.mjs` (must exit 0)
|
|
*/
|
|
|
|
import pkg from 'ssh2'
|
|
const { Server, Client, utils } = pkg
|
|
import { createHash } from 'crypto'
|
|
|
|
function fingerprintOf(key) {
|
|
return 'SHA256:' + createHash('sha256').update(key).digest('base64').replace(/=+$/, '')
|
|
}
|
|
|
|
const fail = (msg) => {
|
|
console.error(`FAIL: ${msg}`)
|
|
process.exit(1)
|
|
}
|
|
|
|
// ---- 1. Boot the loopback server -------------------------------------------
|
|
// ssh2's ed25519 keygen turns out a malformed key roughly once per few
|
|
// hundred runs — its own parser then rejects it ("Malformed OpenSSH private
|
|
// key"), which is enough to flake a release build's pretest. The Server
|
|
// constructor parses hostKeys eagerly, so generate until one is accepted.
|
|
function newHostKey() {
|
|
for (let attempt = 0; ; attempt++) {
|
|
const pair = utils.generateKeyPairSync('ed25519')
|
|
try {
|
|
new Server({ hostKeys: [pair.private] }, () => {})
|
|
return pair
|
|
} catch (err) {
|
|
if (attempt >= 9) throw err
|
|
}
|
|
}
|
|
}
|
|
const serverKey = newHostKey()
|
|
let serverPort = 0
|
|
let seenWindowChange = { cols: 0, rows: 0 }
|
|
|
|
const srv = new Server({ hostKeys: [serverKey.private] }, (client) => {
|
|
client.on('authentication', (ctx) => {
|
|
if (ctx.method === 'password' && ctx.username === 'test' && ctx.password === 'test') {
|
|
ctx.accept()
|
|
} else {
|
|
ctx.reject(['password'])
|
|
}
|
|
})
|
|
|
|
client.on('ready', () => {
|
|
client.on('session', (accept, reject) => {
|
|
const session = accept()
|
|
session.on('pty', (accept) => accept())
|
|
session.on('window-change', (accept, reject, info) => {
|
|
seenWindowChange = { cols: info.cols, rows: info.rows }
|
|
accept && accept()
|
|
})
|
|
session.on('shell', (accept, reject) => {
|
|
const stream = accept()
|
|
stream.write('LOOPBACK-OK\n')
|
|
stream.on('data', (d) => {
|
|
const data = d.toString('utf8')
|
|
stream.write(data) // echo back
|
|
if (data.includes('exit')) {
|
|
stream.end()
|
|
client.end()
|
|
}
|
|
})
|
|
})
|
|
})
|
|
})
|
|
|
|
client.on('error', (err) => console.error('[server] client error', err.message))
|
|
})
|
|
|
|
await new Promise((resolve, reject) => {
|
|
srv.on('error', reject)
|
|
srv.listen(0, '127.0.0.1', () => {
|
|
serverPort = srv.address().port
|
|
resolve()
|
|
})
|
|
})
|
|
console.log(`[loopback] ssh server listening on 127.0.0.1:${serverPort}`)
|
|
|
|
// ---- 2. Connect with the same params the main ssh service uses --------------
|
|
const client = new Client()
|
|
let bannerSeen = false
|
|
let echoed = false
|
|
let output = ''
|
|
let verifyCalls = 0
|
|
let resolveDone
|
|
const done = new Promise((r) => (resolveDone = r))
|
|
const timer = setTimeout(() => {
|
|
fail(`timed out (client connected: ${client._stream ? 'yes' : 'no'})`)
|
|
}, 10000)
|
|
|
|
client.on('ready', () => {
|
|
console.log('[loopback] client ready')
|
|
client.shell({ term: 'xterm-256color', cols: 80, rows: 24 }, (err, stream) => {
|
|
if (err) return fail(`shell error: ${err.message}`)
|
|
console.log('[loopback] shell open')
|
|
let sentInput = false
|
|
let sentExit = false
|
|
|
|
stream.on('data', (d) => {
|
|
const chunk = d.toString('utf8')
|
|
output += chunk
|
|
if (output.includes('LOOPBACK-OK') && !sentInput) {
|
|
bannerSeen = true
|
|
console.log('[loopback] banner received')
|
|
// exercise resize while the session is live
|
|
stream.setWindow(40, 120, 0, 0)
|
|
sentInput = true
|
|
stream.write('hello loopback\n')
|
|
}
|
|
if (output.includes('hello loopback') && echoed === false) {
|
|
echoed = true
|
|
console.log('[loopback] echo received')
|
|
}
|
|
if (bannerSeen && echoed && !sentExit) {
|
|
sentExit = true
|
|
stream.write('exit\n')
|
|
}
|
|
})
|
|
|
|
stream.on('close', () => {
|
|
clearTimeout(timer)
|
|
console.log('[loopback] stream closed')
|
|
client.end()
|
|
resolveDone()
|
|
})
|
|
})
|
|
})
|
|
|
|
client.on('error', (err) => fail(`client error: ${err.message}`))
|
|
|
|
// hostVerifier mirrors ssh.ts (SHA256 fingerprint; loopback accepts the key)
|
|
client.connect({
|
|
host: '127.0.0.1',
|
|
port: serverPort,
|
|
username: 'test',
|
|
password: 'test',
|
|
keepaliveInterval: 0,
|
|
hostVerifier: (hostKey, verify) => {
|
|
verifyCalls++
|
|
const fp = fingerprintOf(hostKey)
|
|
console.log(`[loopback] hostVerifier called (${verifyCalls}), fp=${fp}`)
|
|
verify(true)
|
|
}
|
|
})
|
|
|
|
// ---- 3. Assertions ----------------------------------------------------------
|
|
await done
|
|
srv.close()
|
|
|
|
const checks = [
|
|
['client reached ready', bannerSeen],
|
|
['banner LOOPBACK-OK received', bannerSeen],
|
|
['typed data echoed back', echoed],
|
|
['host key verified exactly once', verifyCalls === 1],
|
|
['resize propagated to server (40x120)', seenWindowChange.cols === 120 && seenWindowChange.rows === 40]
|
|
]
|
|
|
|
let ok = true
|
|
for (const [label, pass] of checks) {
|
|
console.log(`[loopback] ${pass ? 'PASS' : 'FAIL'}: ${label}`)
|
|
if (!pass) ok = false
|
|
}
|
|
|
|
if (!ok) fail('one or more checks failed')
|
|
console.log('[loopback] ALL CHECKS PASSED')
|
|
process.exit(0) |